94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090 | class DocstringChecker:
"""
!!! note "Summary"
Main class for checking docstring format and completeness.
"""
def __init__(self, config: Config) -> None:
"""
!!! note "Summary"
Initialize the docstring checker.
Params:
config (Config):
Configuration object containing global settings and section definitions.
"""
self.config = config
self.sections_config: list[SectionConfig] = config.sections
self.required_sections: list[SectionConfig] = [s for s in config.sections if s.required]
self.optional_sections: list[SectionConfig] = [s for s in config.sections if not s.required]
def check_file(self, file_path: Union[str, Path]) -> list[DocstringError]:
"""
!!! note "Summary"
Check docstrings in a Python file.
Params:
file_path (Union[str, Path]):
Path to the Python file to check.
Raises:
(FileNotFoundError):
If the file doesn't exist.
(InvalidFileError):
If the file is not a Python file.
(UnicodeError):
If the file can't be decoded.
(SyntaxError):
If the file contains invalid Python syntax.
Returns:
(list[DocstringError]):
List of DocstringError objects for any validation failures.
"""
file_path = Path(file_path)
if not file_path.exists():
raise FileNotFoundError(f"File not found: {file_path}")
if file_path.suffix != ".py":
raise InvalidFileError(f"File must be a Python file (.py): {file_path}")
# Read and parse the file
try:
with open(file_path, encoding="utf-8") as f:
content: str = f.read()
except UnicodeDecodeError as e:
raise UnicodeError(f"Cannot decode file {file_path}: {e}") from e
try:
tree: ast.Module = ast.parse(content)
except SyntaxError as e:
raise SyntaxError(f"Invalid Python syntax in {file_path}: {e}") from e
# Extract all functions and classes
items: list[FunctionAndClassDetails] = self._extract_items(tree)
# Check each item
errors: list[DocstringError] = []
for item in items:
try:
self._check_single_docstring(item, str(file_path))
except DocstringError as e:
errors.append(e)
return errors
def check_directory(
self,
directory_path: Union[str, Path],
exclude_patterns: Optional[list[str]] = None,
) -> dict[str, list[DocstringError]]:
"""
!!! note "Summary"
Check docstrings in all Python files in a directory recursively.
Params:
directory_path (Union[str, Path]):
Path to the directory to check.
exclude_patterns (Optional[list[str]]):
List of glob patterns to exclude.
Raises:
(FileNotFoundError):
If the directory doesn't exist.
(DirectoryNotFoundError):
If the path is not a directory.
Returns:
(dict[str, list[DocstringError]]):
Dictionary mapping file paths to lists of DocstringError objects.
"""
directory_path = Path(directory_path)
if not directory_path.exists():
raise FileNotFoundError(f"Directory not found: {directory_path}")
if not directory_path.is_dir():
raise DirectoryNotFoundError(f"Path is not a directory: {directory_path}")
python_files: list[Path] = list(directory_path.glob("**/*.py"))
# Filter out excluded patterns
if exclude_patterns:
filtered_files: list[Path] = []
for file_path in python_files:
relative_path: Path = file_path.relative_to(directory_path)
should_exclude = False
for pattern in exclude_patterns:
if fnmatch.fnmatch(str(relative_path), pattern):
should_exclude = True
break
if not should_exclude:
filtered_files.append(file_path)
python_files = filtered_files
# Check each file
results: dict[str, list[DocstringError]] = {}
for file_path in python_files:
try:
errors: list[DocstringError] = self.check_file(file_path)
if errors: # Only include files with errors
results[str(file_path)] = errors
except (FileNotFoundError, ValueError, SyntaxError) as e:
# Create a special error for file-level issues
error = DocstringError(
message=str(e),
file_path=str(file_path),
line_number=0,
item_name="",
item_type="file",
)
results[str(file_path)] = [error]
return results
def _is_overload_function(self, node: Union[ast.FunctionDef, ast.AsyncFunctionDef]) -> bool:
"""
!!! note "Summary"
Check if a function definition is decorated with @overload.
Params:
node (Union[ast.FunctionDef, ast.AsyncFunctionDef]):
The function node to check for @overload decorator.
Returns:
(bool):
True if the function has @overload decorator, False otherwise.
"""
for decorator in node.decorator_list:
# Handle direct name reference: @overload
if isinstance(decorator, ast.Name) and decorator.id == "overload":
return True
# Handle attribute reference: @typing.overload
elif isinstance(decorator, ast.Attribute) and decorator.attr == "overload":
return True
return False
def _extract_items(self, tree: ast.AST) -> list[FunctionAndClassDetails]:
"""
!!! note "Summary"
Extract all functions and classes from the AST.
Params:
tree (ast.AST):
The Abstract Syntax Tree (AST) to extract items from.
Returns:
(list[FunctionAndClassDetails]):
A list of extracted function and class details.
"""
items: list[FunctionAndClassDetails] = []
class ItemVisitor(ast.NodeVisitor):
"""
!!! note "Summary"
AST visitor to extract function and class definitions
"""
def __init__(self, checker: DocstringChecker) -> None:
"""
!!! note "Summary"
Initialize the AST visitor.
"""
self.class_stack: list[str] = []
self.checker: DocstringChecker = checker
def visit_ClassDef(self, node: ast.ClassDef) -> None:
"""
!!! note "Summary"
Visit class definition node.
"""
# Skip private classes unless check_private is enabled
should_check: bool = self.checker.config.global_config.check_private or not node.name.startswith("_")
if should_check:
items.append(
FunctionAndClassDetails(
item_type="class",
name=node.name,
node=node,
lineno=node.lineno,
parent_class=None,
)
)
# Visit methods in this class
self.class_stack.append(node.name)
self.generic_visit(node)
self.class_stack.pop()
def visit_FunctionDef(self, node: ast.FunctionDef) -> None:
"""
!!! note "Summary"
Visit function definition node.
"""
self._visit_function(node)
def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> None:
"""
!!! note "Summary"
Visit async function definition node.
"""
self._visit_function(node)
def _visit_function(self, node: Union[ast.FunctionDef, ast.AsyncFunctionDef]) -> None:
"""
!!! note "Summary"
Visit function definition node (sync or async).
"""
# Skip private functions unless check_private is enabled
should_check: bool = self.checker.config.global_config.check_private or not node.name.startswith("_")
if should_check:
# Skip @overload functions - they don't need docstrings
if not self.checker._is_overload_function(node):
item_type: Literal["function", "method"] = "method" if self.class_stack else "function"
parent_class: Optional[str] = self.class_stack[-1] if self.class_stack else None
items.append(
FunctionAndClassDetails(
item_type=item_type,
name=node.name,
node=node,
lineno=node.lineno,
parent_class=parent_class,
)
)
self.generic_visit(node)
visitor = ItemVisitor(self)
visitor.visit(tree)
return items
def _check_single_docstring(self, item: FunctionAndClassDetails, file_path: str) -> None:
"""
!!! note "Summary"
Check a single function or class docstring.
Params:
item (FunctionAndClassDetails):
The function or class to check.
file_path (str):
The path to the file containing the item.
Returns:
(None):
Nothing is returned.
"""
docstring: Optional[str] = ast.get_docstring(item.node)
# Check if any required sections apply to this item type
requires_docstring = False
applicable_sections: list[SectionConfig] = []
for section in self.sections_config:
if section.required:
# Check if this section applies to this item type
if section.type == "free_text":
# Free text sections apply only to functions and methods, not classes
if isinstance(item.node, (ast.FunctionDef, ast.AsyncFunctionDef)):
requires_docstring = True
applicable_sections.append(section)
elif section.type == "list_name_and_type":
if section.name.lower() == "params" and isinstance(
item.node, (ast.FunctionDef, ast.AsyncFunctionDef)
):
# Params only apply to functions/methods
requires_docstring = True
applicable_sections.append(section)
elif section.name.lower() in ["returns", "return"] and isinstance(
item.node, (ast.FunctionDef, ast.AsyncFunctionDef)
):
# Returns only apply to functions/methods
requires_docstring = True
applicable_sections.append(section)
elif section.type in ["list_type", "list_name"]:
# These sections apply to functions/methods that might have them
if isinstance(item.node, (ast.FunctionDef, ast.AsyncFunctionDef)):
requires_docstring = True
applicable_sections.append(section)
if not docstring:
# Only require docstrings if the global flag is enabled
if requires_docstring and self.config.global_config.require_docstrings:
message: str = f"Missing docstring for {item.item_type}"
raise DocstringError(
message=message,
file_path=file_path,
line_number=item.lineno,
item_name=item.name,
item_type=item.item_type,
)
return # No docstring required or docstring requirement disabled
# Validate docstring sections if docstring exists
self._validate_docstring_sections(docstring, item, file_path)
def _validate_docstring_sections(
self,
docstring: str,
item: FunctionAndClassDetails,
file_path: str,
) -> None:
"""
!!! note "Summary"
Validate the sections within a docstring.
Params:
docstring (str):
The docstring to validate.
item (FunctionAndClassDetails):
The function or class to check.
file_path (str):
The path to the file containing the item.
Returns:
(None):
Nothing is returned.
"""
errors: list[str] = []
# Check each required section
for section in self.required_sections:
if section.type == "free_text":
if not self._check_free_text_section(docstring, section):
errors.append(f"Missing required section: {section.name}")
elif section.type == "list_name_and_type":
if section.name.lower() == "params" and isinstance(item.node, (ast.FunctionDef, ast.AsyncFunctionDef)):
if not self._check_params_section(docstring, item.node):
errors.append("Missing or invalid Params section")
elif section.name.lower() in ["returns", "return"]:
if not self._check_returns_section(docstring):
errors.append("Missing or invalid Returns section")
elif section.type == "list_type":
if section.name.lower() in ["raises", "raise"]:
if not self._check_raises_section(docstring):
errors.append("Missing or invalid Raises section")
elif section.name.lower() in ["yields", "yield"]:
if not self._check_yields_section(docstring):
errors.append("Missing or invalid Yields section")
elif section.type == "list_name":
# Simple name sections - check if they exist
if not self._check_simple_section(docstring, section.name):
errors.append(f"Missing required section: {section.name}")
# Check section order
order_errors: list[str] = self._check_section_order(docstring)
errors.extend(order_errors)
# Check for mutual exclusivity (returns vs yields)
if self._has_both_returns_and_yields(docstring):
errors.append("Docstring cannot have both Returns and Yields sections")
# Check for undefined sections in docstring (only if not allowed)
if not self.config.global_config.allow_undefined_sections:
undefined_errors: list[str] = self._check_undefined_sections(docstring)
errors.extend(undefined_errors)
# Check admonition values match configuration
admonition_errors: list[str] = self._check_admonition_values(docstring)
errors.extend(admonition_errors)
# Check colon usage for admonition vs non-admonition sections
colon_errors: list[str] = self._check_colon_usage(docstring)
errors.extend(colon_errors)
# Check title case for non-admonition sections
title_case_errors: list[str] = self._check_title_case_sections(docstring)
errors.extend(title_case_errors)
# Check parentheses for list type sections
parentheses_errors: list[str] = self._check_parentheses_validation(docstring)
errors.extend(parentheses_errors)
if errors:
combined_message: str = "; ".join(errors)
raise DocstringError(
message=combined_message,
file_path=file_path,
line_number=item.lineno,
item_name=item.name,
item_type=item.item_type,
)
def _check_free_text_section(self, docstring: str, section: SectionConfig) -> bool:
"""
!!! note "Summary"
Check if a free text section exists in the docstring.
Params:
docstring (str):
The docstring to check.
section (SectionConfig):
The section configuration to validate.
Returns:
(bool):
`True` if the section exists, `False` otherwise.
"""
if isinstance(section.admonition, str) and section.admonition and section.prefix:
# Format like: !!! note "Summary"
# Make the section name part case-insensitive too
escaped_name = re.escape(section.name)
pattern = rf'{re.escape(section.prefix)}\s+{re.escape(section.admonition)}\s+"[^"]*{escaped_name}[^"]*"'
return bool(re.search(pattern, docstring, re.IGNORECASE))
elif section.name.lower() in ["summary"]:
# For summary, accept either formal format or simple docstring
formal_pattern = r'!!! note "Summary"'
if re.search(formal_pattern, docstring, re.IGNORECASE):
return True
# Accept any non-empty docstring as summary
return len(docstring.strip()) > 0
elif section.name.lower() in ["examples", "example"]:
# Look for examples section
return bool(re.search(r'\?\?\?\+ example "Examples"', docstring, re.IGNORECASE))
return True # Default to true for unknown free text sections
def _check_params_section(self, docstring: str, node: Union[ast.FunctionDef, ast.AsyncFunctionDef]) -> bool:
"""
!!! note "Summary"
Check if the Params section exists and documents all parameters.
Params:
docstring (str):
The docstring to check.
node (Union[ast.FunctionDef, ast.AsyncFunctionDef]):
The function node to check.
Returns:
(bool):
`True` if the section exists and is valid, `False` otherwise.
"""
# Get function parameters (excluding 'self' for methods)
params: list[str] = [arg.arg for arg in node.args.args if arg.arg != "self"]
if not params:
return True # No parameters to document
# Check if Params section exists
if not re.search(r"Params:", docstring):
return False
# Check each parameter is documented
for param in params:
param_pattern: str = rf"{re.escape(param)}\s*\([^)]+\):"
if not re.search(param_pattern, docstring):
return False
return True
def _check_returns_section(self, docstring: str) -> bool:
"""
!!! note "Summary"
Check if the Returns section exists.
Params:
docstring (str):
The docstring to check.
Returns:
(bool):
`True` if the section exists, `False` otherwise.
"""
return bool(re.search(r"Returns:", docstring))
def _check_raises_section(self, docstring: str) -> bool:
"""
!!! note "Summary"
Check if the Raises section exists.
Params:
docstring (str):
The docstring to check.
Returns:
(bool):
`True` if the section exists, `False` otherwise.
"""
return bool(re.search(r"Raises:", docstring))
def _has_both_returns_and_yields(self, docstring: str) -> bool:
"""
!!! note "Summary"
Check if docstring has both Returns and Yields sections.
Params:
docstring (str):
The docstring to check.
Returns:
(bool):
`True` if the section exists, `False` otherwise.
"""
has_returns = bool(re.search(r"Returns:", docstring))
has_yields = bool(re.search(r"Yields:", docstring))
return has_returns and has_yields
def _check_section_order(self, docstring: str) -> list[str]:
"""
!!! note "Summary"
Check that sections appear in the correct order.
Params:
docstring (str):
The docstring to check.
Returns:
(list[str]):
A list of error messages, if any.
"""
# Build expected order from configuration
section_patterns: list[tuple[str, str]] = []
for section in sorted(self.sections_config, key=lambda x: x.order):
if (
section.type == "free_text"
and isinstance(section.admonition, str)
and section.admonition
and section.prefix
):
pattern: str = (
rf'{re.escape(section.prefix)}\s+{re.escape(section.admonition)}\s+".*{re.escape(section.name)}"'
)
section_patterns.append((pattern, section.name))
elif section.name.lower() == "params":
section_patterns.append((r"Params:", "Params"))
elif section.name.lower() in ["returns", "return"]:
section_patterns.append((r"Returns:", "Returns"))
elif section.name.lower() in ["yields", "yield"]:
section_patterns.append((r"Yields:", "Yields"))
elif section.name.lower() in ["raises", "raise"]:
section_patterns.append((r"Raises:", "Raises"))
# Add some default patterns for common sections
default_patterns: list[tuple[str, str]] = [
(r'!!! note "Summary"', "Summary"),
(r'!!! details "Details"', "Details"),
(r'\?\?\?\+ example "Examples"', "Examples"),
(r'\?\?\?\+ success "Credit"', "Credit"),
(r'\?\?\?\+ calculation "Equation"', "Equation"),
(r'\?\?\?\+ info "Notes"', "Notes"),
(r'\?\?\? question "References"', "References"),
(r'\?\?\? tip "See Also"', "See Also"),
]
all_patterns: list[tuple[str, str]] = section_patterns + default_patterns
found_sections: list[tuple[int, str]] = []
for pattern, section_name in all_patterns:
match: Optional[re.Match[str]] = re.search(pattern, docstring, re.IGNORECASE)
if match:
found_sections.append((match.start(), section_name))
# Sort by position in docstring
found_sections.sort(key=lambda x: x[0])
# Build expected order
expected_order: list[str] = [s.name.title() for s in sorted(self.sections_config, key=lambda x: x.order)]
expected_order.extend(
[
"Summary",
"Details",
"Examples",
"Credit",
"Equation",
"Notes",
"References",
"See Also",
]
)
# Check order matches expected order
errors: list[str] = []
last_expected_index = -1
for _, section_name in found_sections:
try:
current_index: int = expected_order.index(section_name)
if current_index < last_expected_index:
errors.append(f"Section '{section_name}' appears out of order")
last_expected_index: int = current_index
except ValueError:
# Section not in expected order list - might be OK
pass
return errors
def _check_yields_section(self, docstring: str) -> bool:
"""
!!! note "Summary"
Check if the Yields section exists.
Params:
docstring (str):
The docstring to check.
Returns:
(bool):
`True` if the section exists, `False` otherwise.
"""
return bool(re.search(r"Yields:", docstring))
def _check_simple_section(self, docstring: str, section_name: str) -> bool:
"""
!!! note "Summary"
Check if a simple named section exists.
Params:
docstring (str):
The docstring to check.
section_name (str):
The name of the section to check for.
Returns:
(bool):
`True` if the section exists, `False` otherwise.
"""
pattern: str = rf"{re.escape(section_name)}:"
return bool(re.search(pattern, docstring, re.IGNORECASE))
def _check_undefined_sections(self, docstring: str) -> list[str]:
"""
!!! note "Summary"
Check for sections in docstring that are not defined in configuration.
Params:
docstring (str):
The docstring to check.
Returns:
(list[str]):
A list of error messages for undefined sections.
"""
errors: list[str] = []
# Get all configured section names (case-insensitive)
configured_sections: set[str] = {section.name.lower() for section in self.sections_config}
# Common patterns for different section types
section_patterns: list[tuple[str, str]] = [
# Standard sections with colons (but not inside quotes)
(r"^(\w+):\s*", "colon"),
# Admonition sections with various prefixes
(r"(?:\?\?\?[+]?|!!!)\s+\w+\s+\"([^\"]+)\"", "admonition"),
]
found_sections: set[str] = set()
for pattern, pattern_type in section_patterns:
matches: Iterator[re.Match[str]] = re.finditer(pattern, docstring, re.IGNORECASE | re.MULTILINE)
for match in matches:
section_name: str = match.group(1).lower().strip()
# Remove colon if present (for colon pattern matches)
section_name = section_name.rstrip(":")
# Skip empty matches or common docstring content
if not section_name or section_name in ["", "py", "python", "sh", "shell"]:
continue
# Skip code blocks and inline code
if any(char in section_name for char in ["`", ".", "/", "\\"]):
continue
found_sections.add(section_name)
# Check which found sections are not configured
for section_name in found_sections:
if section_name not in configured_sections:
errors.append(f"Section '{section_name}' found in docstring but not defined in configuration")
return errors
def _check_admonition_values(self, docstring: str) -> list[str]:
"""
!!! note "Summary"
Check that admonition values in docstring match configuration.
Params:
docstring (str):
The docstring to check.
Returns:
(list[str]):
A list of error messages for mismatched admonitions.
"""
errors: list[str] = []
# Create mapping of section names to expected admonitions
section_admonitions: dict[str, str] = {}
for section in self.sections_config:
if section.type == "free_text" and isinstance(section.admonition, str) and section.admonition:
section_admonitions[section.name.lower()] = section.admonition.lower()
# Pattern to find all admonition sections
admonition_pattern = r"(?:\?\?\?[+]?|!!!)\s+(\w+)\s+\"([^\"]+)\""
matches: Iterator[re.Match[str]] = re.finditer(admonition_pattern, docstring, re.IGNORECASE)
for match in matches:
actual_admonition: str = match.group(1).lower()
section_title: str = match.group(2).lower()
# Check if this section is configured with a specific admonition
if section_title in section_admonitions:
expected_admonition: str = section_admonitions[section_title]
if actual_admonition != expected_admonition:
errors.append(
f"Section '{section_title}' has incorrect admonition '{actual_admonition}', "
f"expected '{expected_admonition}'"
)
# Check if section shouldn't have admonition but does
section_config: Optional[SectionConfig] = next(
(s for s in self.sections_config if s.name.lower() == section_title), None
)
if section_config and section_config.admonition is False:
errors.append(f"Section '{section_title}' is configured as non-admonition but found as admonition")
return errors
def _check_colon_usage(self, docstring: str) -> list[str]:
"""
!!! note "Summary"
Check that colons are used correctly for admonition vs non-admonition sections.
"""
errors: list[str] = []
# Check admonition sections (should not end with colon)
admonition_pattern = r"(?:\?\?\?[+]?|!!!)\s+\w+\s+\"([^\"]+)\""
matches: Iterator[re.Match[str]] = re.finditer(admonition_pattern, docstring, re.IGNORECASE)
for match in matches:
section_title: str = match.group(1)
has_colon: bool = section_title.endswith(":")
section_title_clean: str = section_title.rstrip(":").lower()
# Find config for this section
section_config: Optional[SectionConfig] = next(
(s for s in self.sections_config if s.name.lower() == section_title_clean), None
)
if section_config and isinstance(section_config.admonition, str) and section_config.admonition:
if has_colon:
errors.append(
f"Section '{section_title_clean}' is an admonition, therefore it should not end with ':', "
f"see: '{match.group(0)}'"
)
# Check non-admonition sections (should end with colon)
non_admonition_pattern = r"^(\w+)(:?)$"
for line in docstring.split("\n"):
line: str = line.strip()
match: Optional[re.Match[str]] = re.match(non_admonition_pattern, line)
if match:
section_name: str = match.group(1).lower()
has_colon: bool = match.group(2) == ":"
# Find config for this section
section_config = next((s for s in self.sections_config if s.name.lower() == section_name), None)
if section_config and section_config.admonition is False:
if not has_colon:
errors.append(
f"Section '{section_name}' is non-admonition, therefore it must end with ':', "
f"see: '{line}'"
)
return errors
def _check_title_case_sections(self, docstring: str) -> list[str]:
"""
!!! note "Summary"
Check that non-admonition sections are single word, title case, and match config name.
"""
errors: list[str] = []
# Pattern to find section headers (single word followed by optional colon)
section_pattern = r"^(\w+):?$"
for line in docstring.split("\n"):
line: str = line.strip()
match: Optional[re.Match[str]] = re.match(section_pattern, line)
if match:
section_word: str = match.group(1)
section_name_lower: str = section_word.lower()
# Check if this is a configured non-admonition section
section_config: Optional[SectionConfig] = next(
(s for s in self.sections_config if s.name.lower() == section_name_lower), None
)
if section_config and section_config.admonition is False:
# Check if it's title case
expected_title_case: str = section_config.name.title()
if section_word != expected_title_case:
errors.append(
f"Section '{section_name_lower}' must be in title case as '{expected_title_case}', "
f"found: '{section_word}'"
)
return errors
def _check_parentheses_validation(self, docstring: str) -> list[str]:
"""
!!! note "Summary"
Check that list_type and list_name_and_type sections have proper parentheses.
"""
errors: list[str] = []
# Get sections that require parentheses
parentheses_sections: list[SectionConfig] = [
s for s in self.sections_config if s.type in ["list_type", "list_name_and_type"]
]
if not parentheses_sections:
return errors
# Check each line in the docstring
lines: list[str] = docstring.split("\n")
current_section = None
type_line_indent = None # Track indentation of type definition lines
for i, line in enumerate(lines):
stripped_line: str = line.strip()
# Detect section headers
# Admonition sections
admonition_match: Optional[re.Match[str]] = re.match(
r"(?:\?\?\?[+]?|!!!)\s+\w+\s+\"([^\"]+)\"", stripped_line, re.IGNORECASE
)
if admonition_match:
section_name: str = admonition_match.group(1).lower()
current_section: Optional[SectionConfig] = next(
(s for s in parentheses_sections if s.name.lower() == section_name), None
)
type_line_indent = None # Reset for new section
continue
# Non-admonition sections - only match actual section headers, not indented content
# Section headers should be at the start of the line (no leading whitespace)
if not line.startswith((" ", "\t")): # Not indented
simple_section_match: Optional[re.Match[str]] = re.match(r"^(\w+):?$", stripped_line)
if simple_section_match:
section_name: str = simple_section_match.group(1).lower()
# Only consider it a section if it matches our known sections
potential_section: Optional[SectionConfig] = next(
(s for s in self.sections_config if s.name.lower() == section_name), None
)
if potential_section:
# This is a real section header
current_section = next(
(s for s in parentheses_sections if s.name.lower() == section_name), None
)
type_line_indent = None # Reset for new section
continue
# If it doesn't match a known section, fall through to content processing
# Check content lines if we're in a parentheses-required section
if current_section and stripped_line and not stripped_line.startswith(("!", "?", "#")):
# Look for parameter/type definitions
if ":" in stripped_line:
# Calculate current line indentation
current_indent = len(line) - len(line.lstrip())
# Skip description lines that start with common description words
description_prefixes = [
"default:",
"note:",
"example:",
"see:",
"warning:",
"info:",
"tip:",
"returns:",
]
is_description_line = any(
stripped_line.lower().startswith(prefix) for prefix in description_prefixes
)
# Skip lines that are clearly descriptions (containing "Default:", etc.)
if (
is_description_line
or "Default:" in stripped_line
or "Output format:" in stripped_line
or "Show examples:" in stripped_line
):
continue
# For list_type sections, we need special handling
if current_section.type == "list_type":
# Check if this line has parentheses at the beginning
if re.search(r"^\s*\([^)]+\):", stripped_line):
# This is a valid type definition line, remember its indentation
type_line_indent = current_indent
continue
else:
# If no type definition has been found yet, allow lines with colons as possible descriptions
if type_line_indent is None:
continue
# Check if this is a description line (more indented than type line)
if current_indent > type_line_indent:
# This is a description line, skip validation
continue
else:
# This should be a type definition but doesn't have proper format
errors.append(
f"Section '{current_section.name}' (type: '{current_section.type}') requires "
f"parenthesized types, see: '{stripped_line}'"
)
# For list_name_and_type sections, check format like "name (type):" or "(type):"
elif current_section.type == "list_name_and_type":
# Check if this line has parentheses and looks like a parameter definition
if re.search(r"\([^)]+\):", stripped_line):
# This is a valid parameter definition line, remember its indentation
type_line_indent = current_indent
continue
else:
# Check if this is likely a description line based on various criteria
colon_part = stripped_line.split(":")[0].strip()
# Skip if it contains phrases that indicate it's a description, not a parameter
if any(
word in colon_part.lower()
for word in ["default", "output", "format", "show", "example"]
):
continue
# Skip if it starts with bullet points or list markers
if stripped_line.strip().startswith(("-", "*", "•", "+")):
continue
# If we have found a parameter definition, check if this is a description line
if type_line_indent is not None:
# Skip if this is more indented than the parameter definition (description line)
if current_indent > type_line_indent:
continue
# Skip if the line before the colon contains multiple words (likely description)
words_before_colon = colon_part.split()
if len(words_before_colon) > 2: # More than "param_name (type)"
continue
# Only flag lines that could reasonably be parameter definitions
if ":" in stripped_line and not stripped_line.strip().startswith("#"):
errors.append(
f"Section '{current_section.name}' (type: '{current_section.type}') requires "
f"parenthesized types, see: '{stripped_line}'"
)
return errors
|